Mailing Lists: Apple Mailing Lists

Image of Mac OS face in stamp
 
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: String memory leak



Bruce Truax <email@hidden> wrote:

> The command line tool "leaks" is telling me that I have an 80 byte leak of
> type NSCFString everytime I execute the following method:
> 
> - (void)GLASS:(NSString *)parameterString
> {
>     [aSurface setGlass:[NSString stringWithFormat:
>         @"GLASS %@", parameterString]];
>     [aSurface setSurfaceNumber:surfaceNumber];
>     surfaceNumber++;
>     [surfaceArray    addObject:aSurface];
>     aSurface = [[ACSurface alloc]init];
> }

It's not obvious to me why you're apparently leaking an NSCFString each
time, but you're certainly causing an instance of /ACSurface/ to be
leaked (later) after every invocation of -GLASS.  You need to -release
the original aSurface instance just before you trash your reference to
it in the last line of that method.  The array will look after its own
reference to aSurface.

In other words, do this:

- (void)GLASS:(NSString *)parameterString
{
     [aSurface setGlass:[NSString stringWithFormat:
         @"GLASS %@", parameterString]];
     [aSurface setSurfaceNumber:surfaceNumber];
     surfaceNumber++;
     [surfaceArray addObject:aSurface];
     [aSurface release];                   // <-----------
     aSurface = [[ACSurface alloc]init];
}

Peter
 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Cocoa-dev mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/email@hidden

This email sent to email@hidden

References: 
 >String memory leak (From: Bruce Truax <email@hidden>)



Visit the Apple Store online or at retail locations.
1-800-MY-APPLE

Contact Apple | Terms of Use | Privacy Policy

Copyright © 2007 Apple Inc. All rights reserved.