Re: Crashing from undo/redo using "replaceSelectionWithText"

• Subject: Re: Crashing from undo/redo using "replaceSelectionWithText"
• From: "Jing Chen (Volt)" <email@hidden>
• Date: Tue, 12 Feb 2008 18:08:16 -0800
• Accept-language: en-US
• Acceptlanguage: en-US
• Delivered-to: email@hidden
• Delivered-to: email@hidden
• Thread-index: Acht4oEAZ626uGhLTJ+Ye2aiWKdoLwAAspnO
• Thread-topic: Crashing from undo/redo using "replaceSelectionWithText"

On Feb 12, 2008, at 4:28 PM, Jing Chen (Volt) wrote:

Hi all,
 
 I’m having a problem with the undo/redo that is implemented in WebKit. When I do something that alters the selected text (like [WebView replaceSelectionWithText] or changing the font of the selected text) inside of the delegate method of NSComboBox, comboBoxSelectionDidChange, the undo/redo behaves incorrectly. For example:
 
 

1. Type “123”
2. Select “2” and trigger the NSComboBox delegate notification, which is supposed to replace the selection with “foo”. The result is “1fooc”
3. Undo. This gives “foo123”, should give “123”
4. Redo. This gives “foo1foo3”, should give “1foo3”
5. Undo twice. This gives “foo”, should give the empty string (original starting point).
   

Is it possible that comboBoxSelectionDidChange is being called during any of the editing operations that are performed on the text?  For example, perhaps it is called during the Undo operation, which might explain the extraneous "foo" that appears before "123".

Justin

 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Webkitsdk-dev mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:

This email sent to email@hidden

• Prev by Date: Re: Crashing from undo/redo using "replaceSelectionWithText"
• Next by Date: Adding own code to Safari?
• Previous by thread: Re: Crashing from undo/redo using "replaceSelectionWithText"
• Next by thread: Adding own code to Safari?
• Index(es):
  • Date
  • Thread