site_archiver@lists.apple.com Delivered-To: cocoa-dev@lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ax+xPf+ZcgI6lhaoRvHRe/KIjLhG9yxzCzw0f0UTuJI=; b=htiN9k8XO0HlEDwgnNwf/Uyo2+aihSJYlhFl0Ax01dOTG2F+hdoM9ok5EZaiMCrzdf zhkQ0BQgNh7yWNS7VbGz5tuuEHHUvj3fN4SUZ4DKFhmXKaxWr1JRDwA8vjiV6QE1llmJ FJfv8amvTo59m1citO47uEt18Od+I0X8Q7udNI2kJNSyOY/u99q53h+MI3b3kyGOy/9q FgkRJ6jUBApVSmhwMuYHq3PHLzg5hMxsZV+Fqe+4n4dJMxentDQeW93+eFD7AaGfHoLx /IzZzwwiIqn7I0SMYKJjIZ0Hu3cy2jg2WJtAfvaM1YEtZoXDPM0F2LtKuLp107UwAw8o pq/w==

On Aug 8, 2017, at 9:09, Jens Alfke <jens@mooseyard.com> wrote:

...

On Aug 7, 2017, at 5:02 PM, David Hoerl <dhoerl@mac.com> wrote:

But then I though - heck, if Foo has NSObject as its super class, gee, maybe -init isn't really need. I mean, if all of Foo's ivars and properties are initialized, its a shortcut, right.

-[NSObject init] happens to be a no-op empty method. So if a direct subclass of NSObject has no -init method of its own, you could get by with just calling +alloc. However, I think this would be a really bad idea. If at some point you needed to add an -init method to class Foo, like to initialize an ivar, you’d have to go and fix all this code that wasn’t calling -init, or else you’d suddenly have a number of bugs in your code. Even worse, if someone else added the -init method and didn’t know about this quirk of how callers initialized Foo, they might have no idea why their method didn’t get called. Yuck.

—Jens _______________________________________________

It definitely should never pass in a code review for exactly these reasons and should be fixed by either adding the init call or changing the alloc call to a new call (since new is a synonym for alloc init). If you saw it pre-existing in code that was being checked in, require it to be fixed. Refusal to type a few characters is absolutely a shortcut to trouble later (Y2K). _______________________________________________ Cocoa-dev mailing list (Cocoa-dev@lists.apple.com) Please do not post admin requests or moderator comments to the list. Contact the moderators at cocoa-dev-admins(at)lists.apple.com Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/cocoa-dev/site_archiver%40lists.appl... This email sent to site_archiver@lists.apple.com