_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (Darwin-dev(a)lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap…
This email sent to site_archiver(a)lists.apple.com
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (Darwin-dev(a)lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap…
This email sent to site_archiver(a)lists.apple.com
On Apr 13, 2016, at 00:04 , Stephane Sudre wrote:
> There is some "strange" code in the latest xar project (302):
>
> archive.c - line 802:
>
> if( previousAttr == NULL )
> XAR(previousAttr)->attrs = XAR_ATTR(currentAttr)->next;
Certainly looks like bad code (the 0-page is not mapped in, ISTR).
--
Justin C. Walker, Curmudgeon at Large
Director
Institute for the Enhancement of the Director's income
-----------
Question 43:
What if the hokey pokey
really *is* what it’s all about?
--
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (Darwin-dev(a)lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap…
This email sent to site_archiver(a)lists.apple.com
> There is some "strange" code in the latest xar project (302):
>
> archive.c - line 802:
>
> if( previousAttr == NULL )
> XAR(previousAttr)->attrs = XAR_ATTR(currentAttr)->next;
At a very superficial glance, it really looks like that should be XAR(x).
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (Darwin-dev(a)lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap…
This email sent to site_archiver(a)lists.apple.com
There is some "strange" code in the latest xar project (302):
archive.c - line 802:
if( previousAttr == NULL )
XAR(previousAttr)->attrs = XAR_ATTR(currentAttr)->next;
with:
#define XAR(x) ((struct __xar_t *)(x))
At least, Xcode static analyzer is not happy. It's also not happy in
14 other locations in the source code.
Bug ID#25698642
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (Darwin-dev(a)lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap…
This email sent to site_archiver(a)lists.apple.com