September 2017 - Darwin-dev

Re: gmtime_r bug in High Sierra?
by Stephane Sudre 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=04cy53UQuhNb3KwxqDDRWa3y7TPa6ZdwKbQtQzi63yo=; b=GTYHTv8Rr6fTF6kpbRQ96EP8+mK2xGPqKPtoJMhVK6A46FcqMxXPfuZlUDNmiES954 aXIGI/MWb/xwrCFkTPzwOaC3KPxpnRJSEtVh1Sl9kqukaAa8ePRPGNZMKoH96zxllTJY aRDcwMkjvMs1Hki/NkqRGvSGruXKNtiCzarigSoITVLC/ma4s+27XSSZcyempwmwKcAO baWALB0j6xdLay59ixnbxUINPQclaMK9+IYwaAR+gzoAMyHlpDLfY6nP18mClno1/bTc 7K6Z38W0TIAp/00v2RZv0WuhkQjyjbf3hladiDyF522xjdw3LNPk6VdkoZmch2bkkkQi AMZg== Done. On Sun, Sep 10, 2017 at 5:02 PM, Thomas Tempelmann <tempelmann(a)gmail.com> wrote: >> I shall probably file 4 bug reports (and close the one on gmtime_r) >> since in High Sierra b9: > > > And if you do, please don't forget, as a service to everyone, to copy the > reports to http://openradar.me for everyone to browse. > > Thomas > -- Packaging Resources - http://s.sudre.free.fr/Packaging.html _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Thomas Tempelmann 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4xNV7DeiLIc9dp0JidUmRwGXf7dZsbreSJeDInlk/6A=; b=vURP++zAUzEJm87Sjq5qS/1cxP+zm0Xo3XhuP0kCzu9mlGDAI8mmY3F8juSnulCbJY DwWKHRueO3b1F3NuWozg6Km1x2tjhqtD8vbdyktRGfcikT4vMkM2jGPkjmBuxqHcpeHO c/veF0u5etz60NFWCwO3ft5HPMdBlakcykMuQYV8JySSFPBEZYV10MM4XL5JGtlr/S7i vYVDHsuxnRHiRDyUjpub9VeflydbGphBoHY1E+V0pDY0pEVmOLlRFZ6hPHCETwsVQgSr jTBFIPnxA2bAzcJhBLes48mBV5uMhOSSnsb+LZPyPwLB93iWZiEeXVwW0SeAOVbagK7R cIEA== > > I shall probably file 4 bug reports (and close the one on gmtime_r) > since in High Sierra b9: > And if you do, please don't forget, as a service to everyone, to copy the reports to http://openradar.me for everyone to browse. Thomas _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Stephane Sudre 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FMQXVr65LM8IfLBN7zd70oTMZxEjqV6LyjmWqnpRsRk=; b=i4V9CAs0zpn4L9wLVEVzc4yeJ/IBYwhCfqfJzs9IwWLJcOAlVBfKKWAuMSHI03ZPop 3Byb2lHOl5FgcJHc6buPnzJ3F4BZetR09cvQTW/Jc5jMVsRzJBKIsfi7/clrSrwOxhQD ZHxn01mIk1bgABawsup62uD/0194a+XpZCDHwMVBvoiHH6H2ZlF0678qwqxrFGvMMC+2 40Eg0X8G4x/vV1JzBWi7dOwI94M0vVwEbCjDcGzSTtFpq+ZzvRYGqzSbDtBVA+Ld7SeQ jkU7jv2jh7mZtMXudZ5lg7UzyWJWDJpBAkHZJ3JqIKQzM3zc1ItvNPdAAxgxnBSXeXE5 7vYQ== \o/ Adding __attribute__((packed)); seems to fix the issue in my executable. Thanks for the solution. I've never used the getattrlist before, so finding the origin of the issue could have taken me days (I was thinking that the problem could also be with the value set during the creation of the file). I shall probably file 4 bug reports (and close the one on gmtime_r) since in High Sierra b9: (1) xar -cf creates a toc with apparently random FinderCreateTime values. (2) pkgutil --flatten creates a toc with FinderCreateTime values set to Epoch times. (3) productbuild --component creates a toc with apparently random FinderCreateTime values. (4) the latest public source code of xar does not set the packed __attribute__ (1), (2) and (3) are probably related to (4) as these 3 tools are linked directly or indirectly to libxar. On Sun, Sep 10, 2017 at 9:08 AM, Thomas Tempelmann <tempelmann(a)gmail.com> wrote: > On Sun, Sep 10, 2017 at 8:13 AM, Stephane Sudre <dev.iceberg(a)gmail.com> > wrote: > >> So now, it looks like the problem is earlier in the code and it comes >> from the value returned by getattrlist(2). >> >> If I run the code (*) for a file on a HFS+ volume, the value looks >> correct. >> If I run the code for a file on a APFS volume, the value looks incorrect. > > > I just made a quick test app from the xar code you mentioned. One thing to > keep in mind is to use a "pack" instruction with the attribute struct > returned by getattrlist. With this code, it works on both 10.13 and 10.12.6, > on APFS and HFS, correctly: > > #include <unistd.h> > #include <time.h> > #include <string.h> > #include <stdio.h> > #include <sys/attr.h> > > int main(int argc, const char * argv[]) > { > if (argc < 2) { > fprintf(stderr, "Must provide a file path\n"); > } else { > const char *path = argv[1]; > struct fits { > uint32_t length; > struct timespec ts; > } __attribute__((packed)); > struct fits fts; > struct attrlist attrs; > memset(&attrs, 0, sizeof(attrs)); > attrs.bitmapcount = ATTR_BIT_MAP_COUNT; > attrs.commonattr = ATTR_CMN_CRTIME; > int ret = getattrlist(path, &attrs, &fts, sizeof(fts), 0); > if (ret) { > perror(argv[0]); > } else { > char tmpc[64]; > struct tm tm; > gmtime_r(&fts.ts.tv_sec, &tm); > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > printf("crtime: %s and %ld ns\n",tmpc, fts.ts.tv_nsec); > } > } > return 0; > } > > So, based on this, there's no bug in the API. If you find a specific case > where this still doesn't work for you, please let us know. > > Thomas > -- Packaging Resources - http://s.sudre.free.fr/Packaging.html _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Thomas Tempelmann 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z2sXZi5dtZcqVVgB4nsx/gteEVJ+HsGGuJOgquC7eB4=; b=uYsZLDdwp6vERJD25e4LZ/obgU00eHWBakWKdnffc4aWqtUVs/3A0LrkjzshReGAVE bAmL7WEEygwP5C2bor77md46lFkaafM2HMHsGT9kUsO+eFzWvaPxDjk9QI9gv7BvRovS rFEZQTU7XQDkoEN8J8talxGR00CWW6Zncs688qPpnxfc5bTRegqs/B2DzBIQLtr6P0dR leRZNUUi6YmzyW+dOmfB4eXe4CQhT8jGNNH1eXZunABiO4jnBk0KIj1/Iy7Po06xA8Oz AFxwc6IcvBE6o5zBy6IDGCPwfxfGc69xaVtBNmcugQq+4V0IlZVPV+V522ESCqHf7cO/ WWFw== On Sun, Sep 10, 2017 at 8:13 AM, Stephane Sudre <dev.iceberg(a)gmail.com> wrote: So now, it looks like the problem is earlier in the code and it comes > from the value returned by getattrlist(2). > > If I run the code (*) for a file on a HFS+ volume, the value looks correct. > If I run the code for a file on a APFS volume, the value looks incorrect. > I just made a quick test app from the xar code you mentioned. One thing to keep in mind is to use a "pack" instruction with the attribute struct returned by getattrlist. With this code, it works on both 10.13 and 10.12.6, on APFS and HFS, correctly: #include <unistd.h> #include <time.h> #include <string.h> #include <stdio.h> #include <sys/attr.h> int main(int argc, const char * argv[]) { if (argc < 2) { fprintf(stderr, "Must provide a file path\n"); } else { const char *path = argv[1]; struct fits { uint32_t length; struct timespec ts; } __attribute__((packed)); struct fits fts; struct attrlist attrs; memset(&attrs, 0, sizeof(attrs)); attrs.bitmapcount = ATTR_BIT_MAP_COUNT; attrs.commonattr = ATTR_CMN_CRTIME; int ret = getattrlist(path, &attrs, &fts, sizeof(fts), 0); if (ret) { perror(argv[0]); } else { char tmpc[64]; struct tm tm; gmtime_r(&fts.ts.tv_sec, &tm); strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); printf("crtime: %s and %ld ns\n",tmpc, fts.ts.tv_nsec); } } return 0; } So, based on this, there's no bug in the API. If you find a specific case where this still doesn't work for you, please let us know. Thomas _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Thomas Tempelmann 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7/VIyqKTXSDEjBLEv/CkZ/kUE27sOEJz+Y06XPDP9eY=; b=mzVl4CL78ElHt/GTrMsVtL1XuiceIGFpc3j6TCUlc7dVHjLQpzqXF1/LzFGJMRiS6f O2l5jStcH2Oxl6eXJqTG4R2jHgF0Jt6WUpb9TXiprxHWpXJtKom6ZXn6I5NKIsb2e4KU swIa2rm6W/jfUbd9X8OW56aMZtlaueSFzPAdioeg+43LvgV/H7V1OYp1Yn1Cf4AnErF7 ZyoRA8XIY4u9SHLqjwEjMNs6Yyko6OnZj6Jnso5Mq/3XUH0te2huc8Qo8ZiI9xA6GQzQ FnD4nI33JgFBHOScAKCPdloOZe8HIJbhyin1pj01QdPMMuvqJsvwz9x9NksVgZiIrJ0n ujnA== With this comment, I'll cross-post this to the filesystem-dev list, as this could be a bug in the APFS code, making this a bit urgent with the imminent release of 10.13 But it could also be that there's a new(?) flag somewhere that you need to test in order to tell whether the values are in seconds or microseconds. Maybe someone on the filesystem list could clarify this? Thomas On Sun, Sep 10, 2017 at 8:13 AM, Stephane Sudre <dev.iceberg(a)gmail.com> wrote: > Very interesting. Thanks. > > As a matter of fact, the code (and the value sent to gmtime_r) are > extracted from the xar Apple source code (and when it's run on High > Sierra): > > https://opensource.apple.com/source/xar/xar-357/xar/lib/ > darwinattr.c.auto.html > > stragglers_archive > > So now, it looks like the problem is earlier in the code and it comes > from the value returned by getattrlist(2). > > If I run the code (*) for a file on a HFS+ volume, the value looks correct. > If I run the code for a file on a APFS volume, the value looks incorrect. > > > * In conditions specific to the code using the xar code, which is a > launchd daemon and playing with a file that was very recently created. > > > > > On Sun, Sep 10, 2017 at 3:23 AM, Stephen J. Butler > <stephen.butler(a)gmail.com> wrote: > > It's not a bug IMHO. The problem is that you don't check the return > value of > > gmtime_r(). If you did, you'd see that the result is NULL (which means > the > > function failed) and so you shouldn't use any of the results (they're > > undefined). > > > > #include <unistd.h> > > #include <time.h> > > #include <string.h> > > #include <stdio.h> > > > > int main(int argc, const char * argv[]) { > > > > char tmpc[128]; > > struct tm tm; > > > > memset(tmpc, 0, sizeof(tmpc)); > > > > __darwin_time_t tValue=2914986787602432000; > > > > if (gmtime_r(&tValue, &tm)) { > > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > > > > printf("time: %s\n",tmpc); > > > > printf("-----------------\n"); > > } > > > > struct tm tm2; > > tm2.tm_mon=10240; > > > > memset(tmpc, 0, sizeof(tmpc)); > > > > tValue=2914986787602432000; > > > > if (gmtime_r(&tValue, &tm2)) { > > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > > > > printf("time: %s\n",tmpc); > > } > > > > return 0; > > } > > > > > > But also here, the number you're providing to tValue looks a lot like > > nanosecond time stamp, and gmtime_r() expects seconds. If you correct > that, > > then you get: > > > > time: 2062-05-16T06:33:07 > > ----------------- > > time: 2062-05-16T06:33:07 > > > > > > On Sat, Sep 9, 2017 at 5:51 PM, Stephane Sudre <dev.iceberg(a)gmail.com> > > wrote: > >> > >> Maybe I'm missing something (regarding the tm var) but shouldn't all > >> the struct tm fields be correctly set by gmtime_r? > >> > >> #include <unistd.h> > >> #include <time.h> > >> #include <string.h> > >> #include <stdio.h> > >> > >> int main(int argc, const char * argv[]) { > >> > >> char tmpc[128]; > >> struct tm tm; > >> > >> memset(tmpc, 0, sizeof(tmpc)); > >> > >> __darwin_time_t tValue=2914986787602432000; > >> > >> gmtime_r(&tValue, &tm); > >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > >> > >> printf("time: %s\n",tmpc); > >> > >> printf("-----------------\n"); > >> > >> struct tm tm2; > >> tm2.tm_mon=10240; > >> > >> memset(tmpc, 0, sizeof(tmpc)); > >> > >> tValue=2914986787602432000; > >> > >> gmtime_r(&tValue, &tm2); > >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > >> > >> printf("time: %s\n",tmpc); > >> > >> return 0; > >> } > >> > >> => > >> > >> time: 1900-01-00T18:40:00 > >> ----------------- > >> time: 1900-10241-00T18:40:00 > >> > _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Stephen J. Butler 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8sQYHF7kLpo2tL1q7Fb4YSqH/BQt6IF0Z1/LaxZhlfk=; b=StCj5T5UAkehuDCVf1G6/NuboNcRp6+CTrHzdA4VkeOE2SzOHpwth0pHjToQpeRTbD RyfAXTgkFoejhwAwKmBMdD8SwZwuEtgYSFFEkbrP5ZMP7BXzNX7MIi72ZNGAlKmZNGGU s58+pEGEZwr4XEU1D5GPueAxCQj0dbS02sb5vKAMNgkNdDdF9+Hzji+3Hy+aTpAKc7H3 WyKM7m00myZoReajGu+IAxdL//LYh8mlKI/4irvqwfaLEikUWUigv2izyfe9qvjwuHRp fcvcjYhzv8xAsnU57abg8CUNLeyFe8ciC983eEID8/L3VcsEdmCHHEoXGS77Od/LkbqP FbVA== APFS has nanosecond based timestamps, and HFS+ only has second based timestamps. You'll need to scale accordingly. On Sun, Sep 10, 2017 at 1:13 AM, Stephane Sudre <dev.iceberg(a)gmail.com> wrote: > Very interesting. Thanks. > > As a matter of fact, the code (and the value sent to gmtime_r) are > extracted from the xar Apple source code (and when it's run on High > Sierra): > > https://opensource.apple.com/source/xar/xar-357/xar/lib/ > darwinattr.c.auto.html > > stragglers_archive > > So now, it looks like the problem is earlier in the code and it comes > from the value returned by getattrlist(2). > > If I run the code (*) for a file on a HFS+ volume, the value looks correct. > If I run the code for a file on a APFS volume, the value looks incorrect. > > > * In conditions specific to the code using the xar code, which is a > launchd daemon and playing with a file that was very recently created. > > > > > On Sun, Sep 10, 2017 at 3:23 AM, Stephen J. Butler > <stephen.butler(a)gmail.com> wrote: > > It's not a bug IMHO. The problem is that you don't check the return > value of > > gmtime_r(). If you did, you'd see that the result is NULL (which means > the > > function failed) and so you shouldn't use any of the results (they're > > undefined). > > > > #include <unistd.h> > > #include <time.h> > > #include <string.h> > > #include <stdio.h> > > > > int main(int argc, const char * argv[]) { > > > > char tmpc[128]; > > struct tm tm; > > > > memset(tmpc, 0, sizeof(tmpc)); > > > > __darwin_time_t tValue=2914986787602432000; > > > > if (gmtime_r(&tValue, &tm)) { > > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > > > > printf("time: %s\n",tmpc); > > > > printf("-----------------\n"); > > } > > > > struct tm tm2; > > tm2.tm_mon=10240; > > > > memset(tmpc, 0, sizeof(tmpc)); > > > > tValue=2914986787602432000; > > > > if (gmtime_r(&tValue, &tm2)) { > > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > > > > printf("time: %s\n",tmpc); > > } > > > > return 0; > > } > > > > > > But also here, the number you're providing to tValue looks a lot like > > nanosecond time stamp, and gmtime_r() expects seconds. If you correct > that, > > then you get: > > > > time: 2062-05-16T06:33:07 > > ----------------- > > time: 2062-05-16T06:33:07 > > > > > > On Sat, Sep 9, 2017 at 5:51 PM, Stephane Sudre <dev.iceberg(a)gmail.com> > > wrote: > >> > >> Maybe I'm missing something (regarding the tm var) but shouldn't all > >> the struct tm fields be correctly set by gmtime_r? > >> > >> #include <unistd.h> > >> #include <time.h> > >> #include <string.h> > >> #include <stdio.h> > >> > >> int main(int argc, const char * argv[]) { > >> > >> char tmpc[128]; > >> struct tm tm; > >> > >> memset(tmpc, 0, sizeof(tmpc)); > >> > >> __darwin_time_t tValue=2914986787602432000; > >> > >> gmtime_r(&tValue, &tm); > >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > >> > >> printf("time: %s\n",tmpc); > >> > >> printf("-----------------\n"); > >> > >> struct tm tm2; > >> tm2.tm_mon=10240; > >> > >> memset(tmpc, 0, sizeof(tmpc)); > >> > >> tValue=2914986787602432000; > >> > >> gmtime_r(&tValue, &tm2); > >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > >> > >> printf("time: %s\n",tmpc); > >> > >> return 0; > >> } > >> > >> => > >> > >> time: 1900-01-00T18:40:00 > >> ----------------- > >> time: 1900-10241-00T18:40:00 > >> _______________________________________________ > >> Do not post admin requests to the list. They will be ignored. > >> Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) > >> Help/Unsubscribe/Update your Subscription: > >> > >> https://lists.apple.com/mailman/options/darwin-dev/ > stephen.butler%40gmail.com > >> > >> This email sent to stephen.butler(a)gmail.com > > > > > > > > -- > Packaging Resources - http://s.sudre.free.fr/Packaging.html > _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Stephane Sudre 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GOyoOwDXRVtLVI5PtfqTCDObf4+++nsAUUu7TqZ2Z7M=; b=KIficYF2q3AOYBIRJo6iboKeBotU9xmt9lPeC4kitiIAuuXFD/QsLNANs887Hp2/Co 2kHs459fTCVpOdBmnyNUwXxwbLza2O1INvIFv0FcZdLRgLocfSkMmsKV8tJNWuhy3u2s erHLYqclrXnV0suvfrXK8OqWMowy5M0nkJa6O9YXQnkTD7r4xhv67mi5CcQy1xoRVFb4 wOq2t7hEusnywgT8qGniCNcJtfNXIVZIUeAO2itVvJOypIOVGN0bHsgr1kmkRMIOKc6v kZQPxdLdieRhlVI7Cp31pmForAggci/GzDZiPOJpb4hCi9W2+H7Wtd7i5J3GXEe54Zb+ mJpA== Very interesting. Thanks. As a matter of fact, the code (and the value sent to gmtime_r) are extracted from the xar Apple source code (and when it's run on High Sierra): https://opensource.apple.com/source/xar/xar-357/xar/lib/darwinattr.c.auto.h… stragglers_archive So now, it looks like the problem is earlier in the code and it comes from the value returned by getattrlist(2). If I run the code (*) for a file on a HFS+ volume, the value looks correct. If I run the code for a file on a APFS volume, the value looks incorrect. * In conditions specific to the code using the xar code, which is a launchd daemon and playing with a file that was very recently created. On Sun, Sep 10, 2017 at 3:23 AM, Stephen J. Butler <stephen.butler(a)gmail.com> wrote: > It's not a bug IMHO. The problem is that you don't check the return value of > gmtime_r(). If you did, you'd see that the result is NULL (which means the > function failed) and so you shouldn't use any of the results (they're > undefined). > > #include <unistd.h> > #include <time.h> > #include <string.h> > #include <stdio.h> > > int main(int argc, const char * argv[]) { > > char tmpc[128]; > struct tm tm; > > memset(tmpc, 0, sizeof(tmpc)); > > __darwin_time_t tValue=2914986787602432000; > > if (gmtime_r(&tValue, &tm)) { > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > > printf("time: %s\n",tmpc); > > printf("-----------------\n"); > } > > struct tm tm2; > tm2.tm_mon=10240; > > memset(tmpc, 0, sizeof(tmpc)); > > tValue=2914986787602432000; > > if (gmtime_r(&tValue, &tm2)) { > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > > printf("time: %s\n",tmpc); > } > > return 0; > } > > > But also here, the number you're providing to tValue looks a lot like > nanosecond time stamp, and gmtime_r() expects seconds. If you correct that, > then you get: > > time: 2062-05-16T06:33:07 > ----------------- > time: 2062-05-16T06:33:07 > > > On Sat, Sep 9, 2017 at 5:51 PM, Stephane Sudre <dev.iceberg(a)gmail.com> > wrote: >> >> Maybe I'm missing something (regarding the tm var) but shouldn't all >> the struct tm fields be correctly set by gmtime_r? >> >> #include <unistd.h> >> #include <time.h> >> #include <string.h> >> #include <stdio.h> >> >> int main(int argc, const char * argv[]) { >> >> char tmpc[128]; >> struct tm tm; >> >> memset(tmpc, 0, sizeof(tmpc)); >> >> __darwin_time_t tValue=2914986787602432000; >> >> gmtime_r(&tValue, &tm); >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); >> >> printf("time: %s\n",tmpc); >> >> printf("-----------------\n"); >> >> struct tm tm2; >> tm2.tm_mon=10240; >> >> memset(tmpc, 0, sizeof(tmpc)); >> >> tValue=2914986787602432000; >> >> gmtime_r(&tValue, &tm2); >> strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); >> >> printf("time: %s\n",tmpc); >> >> return 0; >> } >> >> => >> >> time: 1900-01-00T18:40:00 >> ----------------- >> time: 1900-10241-00T18:40:00 >> _______________________________________________ >> Do not post admin requests to the list. They will be ignored. >> Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) >> Help/Unsubscribe/Update your Subscription: >> >> https://lists.apple.com/mailman/options/darwin-dev/stephen.butler%40gmail.c… >> >> This email sent to stephen.butler(a)gmail.com > > -- Packaging Resources - http://s.sudre.free.fr/Packaging.html _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

Re: gmtime_r bug in High Sierra?
by Stephen J. Butler 10 Sep '17

10 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w4SSlXUa0loy+yzk0uR1DoJepAAqvyQy1qP1V1akuXo=; b=oCmsCBvQruUTOOZ1GNRK1n9E5YONnJ9mKMXiEF9QkIKuzusX+Zf/g2D4T5KrMVyhQK tuPyws2jD21jQVGZK5jXE+JqQRbR9UvOLxV0+NLBOfWMpjo311j/ajW795XkySzlvFtp ZHgrHzP6TA8t0fbqMNnLSiLkevaLr86ywoDOhv9K2zMBseFpROsIKWJJYCGeOAcrXz8y b6oRpu9SZbQv3gm9ABfsY116mgWy7Ob6K6jMuA06XpHbe25QvNjnENY1qarvo3UoymNv sgdrxjKkGfpyMBcXRstQbBykghud80Mfey55w0VStgkGLVHIaIccTUTGWvPUWbz1Ljlz WKKQ== It's not a bug IMHO. The problem is that you don't check the return value of gmtime_r(). If you did, you'd see that the result is NULL (which means the function failed) and so you shouldn't use any of the results (they're undefined). #include <unistd.h> #include <time.h> #include <string.h> #include <stdio.h> int main(int argc, const char * argv[]) { char tmpc[128]; struct tm tm; memset(tmpc, 0, sizeof(tmpc)); __darwin_time_t tValue=2914986787602432000; if (gmtime_r(&tValue, &tm)) { strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); printf("time: %s\n",tmpc); printf("-----------------\n"); } struct tm tm2; tm2.tm_mon=10240; memset(tmpc, 0, sizeof(tmpc)); tValue=2914986787602432000; if (gmtime_r(&tValue, &tm2)) { strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); printf("time: %s\n",tmpc); } return 0; } But also here, the number you're providing to tValue looks a lot like nanosecond time stamp, and gmtime_r() expects seconds. If you correct that, then you get: time: 2062-05-16T06:33:07 ----------------- time: 2062-05-16T06:33:07 On Sat, Sep 9, 2017 at 5:51 PM, Stephane Sudre <dev.iceberg(a)gmail.com> wrote: > Maybe I'm missing something (regarding the tm var) but shouldn't all > the struct tm fields be correctly set by gmtime_r? > > #include <unistd.h> > #include <time.h> > #include <string.h> > #include <stdio.h> > > int main(int argc, const char * argv[]) { > > char tmpc[128]; > struct tm tm; > > memset(tmpc, 0, sizeof(tmpc)); > > __darwin_time_t tValue=2914986787602432000; > > gmtime_r(&tValue, &tm); > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); > > printf("time: %s\n",tmpc); > > printf("-----------------\n"); > > struct tm tm2; > tm2.tm_mon=10240; > > memset(tmpc, 0, sizeof(tmpc)); > > tValue=2914986787602432000; > > gmtime_r(&tValue, &tm2); > strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); > > printf("time: %s\n",tmpc); > > return 0; > } > > => > > time: 1900-01-00T18:40:00 > ----------------- > time: 1900-10241-00T18:40:00 > _______________________________________________ > Do not post admin requests to the list. They will be ignored. > Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) > Help/Unsubscribe/Update your Subscription: > https://lists.apple.com/mailman/options/darwin-dev/ > stephen.butler%40gmail.com > > This email sent to stephen.butler(a)gmail.com > _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

gmtime_r bug in High Sierra?
by Stephane Sudre 09 Sep '17

09 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=AuMRiB27w9EhybboGo4kLwooEWD55niR6/Mgwg09CX0=; b=pehkxmKTWBEDUqU5ifp5xWl/T9Oh78/CwD6h4nm12w+UUsdcF5vPzzJyPrv03UZqgc ks8O+RCBGZ06vFPedkYTA+GP3vdsySUFmE2+qD6duMEjVGzhZPuIAwOKaACqkDsTFEqb E5RidbGz/NzU3yyv0nHeMcQAW+0VimT5S39y2qvuU6IsrK6OjiakE+vfMKrG14zU7aCt ZcVROi4Sh4ALLm8rfyIY0ao4rsKokI7IH9aDrTqPvZc0rglfxuugibz5vglX5HfPjLmh hVdOs44134J1Cu6B7p1Jp1sX6mjxIgWF6XIfL5i2akAroKuv6Hhy19KLGEk8DTQoEhg3 mjoA== Maybe I'm missing something (regarding the tm var) but shouldn't all the struct tm fields be correctly set by gmtime_r? #include <unistd.h> #include <time.h> #include <string.h> #include <stdio.h> int main(int argc, const char * argv[]) { char tmpc[128]; struct tm tm; memset(tmpc, 0, sizeof(tmpc)); __darwin_time_t tValue=2914986787602432000; gmtime_r(&tValue, &tm); strftime(tmpc, sizeof(tmpc), "%FT%T", &tm); printf("time: %s\n",tmpc); printf("-----------------\n"); struct tm tm2; tm2.tm_mon=10240; memset(tmpc, 0, sizeof(tmpc)); tValue=2914986787602432000; gmtime_r(&tValue, &tm2); strftime(tmpc, sizeof(tmpc), "%FT%T", &tm2); printf("time: %s\n",tmpc); return 0; } => time: 1900-01-00T18:40:00 ----------------- time: 1900-10241-00T18:40:00 _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0

IOATABlockStorage Headers
by Clifford Sekel 08 Sep '17

08 Sep '17

site_archiver(a)lists.apple.com Delivered-To: darwin-dev(a)lists.apple.com Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pd-devs-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=yYv+7YvdOm9G0jgALdCCZq5fqIKmjnOarkXyDLKQv0w=; b=ILrtu2z4+kCUB8+eL6vQw4nToq+CKKs41jtWMHfF2KGvlUABY/3TlFPNRxJ2NzuG+5 YP1ji6uJdhrYCZZH/rV9ArzrvNkg3myTeBJAquWajT6dAEKYn3tEOqLCAEb0FdCinwc+ QlAK+r+JovEyzNtnKIdL2HBWNc5YK+FD4oiOLLVvjKZA+F7TxNxsYCjsXR7w6XzUwLL0 FJd9W2JJe57TzOuSZ4thqBSt0iTLqRFIzrsXpxGlOzDkjaicZij5CFUFByPGeQHUQwZX bGOfmf/e9gfPRiX0OQ9NRMTEA+AxEz4oLDoGZaJZZ0yMVMdsLJwpkpYttdTHqgRpFETg EGSA== Devs, Is there anyway to get aleast headers for the project version below so we may update and build IOATABlockStorage that was released again. We're having linking errors because the IOATABlockStorage is out of date causing issues when loading into our image. https://opensource.apple.com/source/IOATABlockStorage/IOATABlockStorage-6459 I have already opened a bug fix for this radar://31914500 Any help would be appericated, even if it's getting some more IOkit Family/Drivers released or such even if it's just headers. Thanks Cliff Sekel PureDarwin Core Dev _______________________________________________ Do not post admin requests to the list. They will be ignored. Darwin-dev mailing list (Darwin-dev(a)lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/darwin-dev/site_archiver%40lists.ap… This email sent to site_archiver(a)lists.apple.com

1 0