• Open Menu Close Menu
  • Apple
  • Shopping Bag
  • Apple
  • Mac
  • iPad
  • iPhone
  • Watch
  • TV
  • Music
  • Support
  • Search apple.com
  • Shopping Bag

Lists

Open Menu Close Menu
  • Terms and Conditions
  • Lists hosted on this site
  • Email the Postmaster
  • Tips for posting to public mailing lists
Releasing ivars in -didTurnIntoFault. Should set to nil?
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Releasing ivars in -didTurnIntoFault. Should set to nil?


  • Subject: Releasing ivars in -didTurnIntoFault. Should set to nil?
  • From: Jerry Krinock <email@hidden>
  • Date: Wed, 12 Aug 2009 11:41:05 -0700

I release a "regular" instance variable in my managed object's - didTurnIntoFault, and discovered that this was causing a crash sometime after an undo. In searching code on the internet I see that others have reported such crashes. I solved the problem by setting the instance variable to nil:

- (void)didTurnIntoFault {
    [childrenTemp release] ; childrenTemp = nil ;

    [super didTurnIntoFault] ;
}

Now I understand that if nilling an instance variable after releasing it is done in -dealloc, it is papering over other memory management problems and is therefore bad programming practice. But I believe that this practice is OK in -didTurnIntoFault because, particularly when Undo is involved, -didTurnIntoFault may be invoked more than once on an object. Therefore nilling after releasing in -didTurnIntoFault is recommended.

Does anyone disagree?

Sincerely,

Jerry Krinock


_______________________________________________

Cocoa-dev mailing list (email@hidden)

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden


  • Follow-Ups:
    • Re: Releasing ivars in -didTurnIntoFault. Should set to nil?
      • From: "Sean McBride" <email@hidden>
  • Prev by Date: Re: [iPhone] CAKeyframeAnimation
  • Next by Date: Re: Adding more and more key/value observers is much too slow - workaround needed.
  • Previous by thread: Line breaks and paragraph breaks
  • Next by thread: Re: Releasing ivars in -didTurnIntoFault. Should set to nil?
  • Index(es):
    • Date
    • Thread