Re: Analyzer in error?
Re: Analyzer in error?
- Subject: Re: Analyzer in error?
- From: Roland King <email@hidden>
- Date: Thu, 14 Jan 2010 10:02:57 +0800
Possibly - do you want to try the XCode list for that one, I've been
asking CLANG questions over there.
Graham Cox wrote:
Hi all, I have the following code in a category on NSData:
@implementation NSData (SHA1Hash)
- (NSData*) sha1Hash
{
// calculates the 160 bit SHA-1 digest of the given data
unsigned char* digest = (unsigned char*) malloc(20);
SHA1([self bytes], [self length], digest);
return [[self class] dataWithBytesNoCopy:digest length:20];
}
@end
The static analyzer reports this:
Potential leak of an object allocated on line 622
Method returns an Objective-C object with a +1 retain count (owning reference)
Object returned to caller as an owning reference (single retain count transferred to caller)
Object allocated on line 622 is returned from a method whose name ('sha1Hash') does not contain 'copy' or otherwise starts with 'new' or 'alloc'. This violates the naming convention rules given in the Memory Management Guide for Cocoa (object leaked)
But I think this is wrong - [NSData dataWithBytesNoCopy] returns an object I don't own, and it in turn takes ownership of <digest>. So where's the leak? Is clang simply mistaking the fact that +dataWithBytesNoCopy CONTAINS 'copy' and not STARTS WITH copy?
--Graham
_______________________________________________
Cocoa-dev mailing list (email@hidden)
Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden
_______________________________________________
Cocoa-dev mailing list (email@hidden)
Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden