• Open Menu Close Menu
  • Apple
  • Shopping Bag
  • Apple
  • Mac
  • iPad
  • iPhone
  • Watch
  • TV
  • Music
  • Support
  • Search apple.com
  • Shopping Bag

Lists

Open Menu Close Menu
  • Terms and Conditions
  • Lists hosted on this site
  • Email the Postmaster
  • Tips for posting to public mailing lists
Re: Fragile code in AUBase.h (diff provided)
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fragile code in AUBase.h (diff provided)


  • Subject: Re: Fragile code in AUBase.h (diff provided)
  • From: William Stewart <email@hidden>
  • Date: Thu, 11 Aug 2005 12:25:10 -0700

From our cvs history, this line was last changed on Aug 10, 2004 - and actually Marc Poirier had pointed this out at that time.

We have left the 1.3.x SDK's alone for quite some time now, and strongly recommend that developers stay on current SDK releases - at this point that is 1.4.1 and we are just waiting for final posting of the 1.4.2 SDK to be completed.

None of the 1.4 SDKs have the code you describe below.

Bill

On 11/08/2005, at 2:18 AM, Brian Willoughby wrote:

Hi folks,

You may want to apply the appended patch to AUBase.h and recompile your AudioUnits.
For no good reason that I can imagine, the AudioUnitParameterInfo flags field is being modified using ADD instead of OR. This means that if your code calls the affected routine(s) more than once, the flags field will be scrambled to a nonsensical and unpredictable value. I am sure that someone could convincingly argue that it would be incredibly unlikely for one of these routines to be called more than once, but since there is no advantage to using ADD, why take any risk?


My Receipts say I have CoreAudio 1.3.5 installed, so this patch applies to the line numbers in that version of AUBase.h

diff AUBase.h~ AUBase.h
522c522
< ioInfo.flags += kAudioUnitParameterFlag_HasCFNameString;
---
> ioInfo.flags |= kAudioUnitParameterFlag_HasCFNameString;
524c524
< ioInfo.flags += kAudioUnitParameterFlag_CFNameRelease;
---
> ioInfo.flags |= kAudioUnitParameterFlag_CFNameRelease;
531c531
< ioInfo.flags += kAudioUnitParameterFlag_HasClump;
---
> ioInfo.flags |= kAudioUnitParameterFlag_HasClump;


Brian Willoughby
Sound Consulting
 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Coreaudio-api mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden

--
mailto:email@hidden
tel: +1 408 974 4056
________________________________________________________________________ __
"Much human ingenuity has gone into finding the ultimate Before.
The current state of knowledge can be summarized thus:
In the beginning, there was nothing, which exploded" - Terry Pratchett
________________________________________________________________________ __


_______________________________________________
Do not post admin requests to the list. They will be ignored.
Coreaudio-api mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden


References: 
 >Fragile code in AUBase.h (diff provided) (From: Brian Willoughby <email@hidden>)

  • Prev by Date: Re: AURenderCallback inputs...
  • Next by Date: Re: CocoaUI & factory class design pattern in ObjC
  • Previous by thread: Fragile code in AUBase.h (diff provided)
  • Next by thread: CocoaUI & factory class design pattern in ObjC
  • Index(es):
    • Date
    • Thread