libmalloc: forget to free something in nano_try_madvise in nano_malloc?
libmalloc: forget to free something in nano_try_madvise in nano_malloc?
- Subject: libmalloc: forget to free something in nano_try_madvise in nano_malloc?
- From: cee1 <email@hidden>
- Date: Tue, 23 Dec 2014 16:22:30 +0800
Hi all,
I'm interesting to the internal of malloc in OS X and learning some
code snippets of it, and I find it seems forget to free page_bitarray
in nano_try_madvise()
(http://www.opensource.apple.com/source/libmalloc/libmalloc-53.1.1/src/nano_malloc.c,
line 1395):
"""
bitarray_t slot_bitarray = bitarray_create(log_size);
bitarray_t page_bitarray = bitarray_create(log_page_count);
if (!slot_bitarray) {
/******* Shouldn't we free(page_bitarray) here？*******/
return bytes_toward_goal;
}
if (!page_bitarray) {
free(slot_bitarray);
return bytes_toward_goal;
}
"""
BTW, in segregated_band_grow(), does it miss an unmap call if return
another vm area that's not what asked for?
"""
kern_return_t kr = mach_vm_map(mach_task_self(), &vm_addr, BAND_SIZE,
0, VM_MAKE_TAG(VM_MEMORY_MALLOC_NANO),
MEMORY_OBJECT_NULL, 0, FALSE,
VM_PROT_DEFAULT, VM_PROT_ALL, VM_INHERIT_DEFAULT);
void *q = (uintptr_t)vm_addr;
if (kr || q != (void *)(p & ~((uintptr_t)(BAND_SIZE - 1)))) //
Must get exactly what we asked for
return FALSE;
"""
--
Regards,
- cee1
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden