Lists

Open Menu Close Menu

Terms and Conditions
Lists hosted on this site
Email the Postmaster
Tips for posting to public mailing lists

Re: kdp_match_name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: kdp_match_name

Subject: Re: kdp_match_name
From: Phil Dennis-Jordan <email@hidden>
Date: Fri, 18 Sep 2015 15:36:39 +0200

On Fri, Sep 18, 2015 at 12:23 AM, Stan Sieler <email@hidden> wrote:

Not a answer for you, but, re:

> […] strncmp(kdpname, "serial", sizeof(kdpname)) != 0)

That struck me as odd. Wouldn’t ’6’ be much better than sizeof(kdpname)?
(Or, wouldn’t using ’strcmp’ be much better here?)

A lot of words have been used to describe how dangerous C string handling is; I'm not going to weigh in with my own fairly redundant opinion, but I'd like to point out that passing 6 as the length here would make any string starting with "serial" match, which is almost certainly not what is intended. (e.g. "serial123" etc.)

Note that there's also not really any difference between passing 7 or a larger number, as the comparison will definitely terminate at the implicit \0 of "serial".

phil

 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Darwin-kernel mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:

This email sent to email@hidden

Follow-Ups:
- Re: kdp_match_name
  - From: Sam Manzer <email@hidden>

References:
	>kdp_match_name (From: Sam Manzer <email@hidden>)
	>Re: kdp_match_name (From: Stan Sieler <email@hidden>)

Prev by Date: Re: kdp_match_name
Next by Date: Re: kdp_match_name
Previous by thread: Re: kdp_match_name
Next by thread: Re: kdp_match_name
Index(es):
- Date
- Thread