Re: Install check logic failing
Re: Install check logic failing
- Subject: Re: Install check logic failing
- From: Mario Emmenlauer <email@hidden>
- Date: Fri, 26 Jun 2009 17:03:18 +0200
Hi,
Taylor Armstrong wrote:
Trying to use PackageMaker for the 1st time (I normally just use
install-ease or Iceberg since most of my packages are fairly simple).
I added a install check that clearly states "Maximum CPU Frequency (Hz)
is less than or equal to 500". It is required, and "Pass if" is set to
"true"
The package fails on a 2x2.8 ghtz Intel box.
Question - am I simply looking at the logic backwards? The "true", in
Well, I would say it equals:
if ((max cpu speed <= 500) == true) then Pass;
else exit with error;
Of course, testing if "(max cpu speed <= 500) equals true" is the same
as just testing if (max cpu speed <= 500). So your test does:
if (max cpu speed <= 500) then Pass;
else exit with error;
which is the opposite of what you want. If you correct it, rather then
testing for false I would suggest testing "if (max cpu speed > 500)",
in case that test exists. It would be a lot more readable:)
Cheers, and happy coding,
Mario
--
Dipl. Inf. Mario Emmenlauer Cell: +49-(0)176-23463809
Bitplane AG Office: +41-(0)44-430-1106
Badenerstrasse 682 Fax: +41-(0)44-430-1101
CH-8048 Zürich mailto:mario * emmenlauer.de
Zürich http://www.marssoft.de / http://www.xuvtools.org
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Installer-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden