D2W query broken
D2W query broken
- Subject: D2W query broken
- From: Ramsey Lee Gurley <email@hidden>
- Date: Sat, 26 Sep 2009 20:01:16 -0400
Hi all, but mainly Travis,
I've noticed a new query validation delegate has made it into
ERDirectToWeb. I like the potential to filter out searches based on
input. However, this implementation is breaking what I have. Empty
queries no longer work. May I suggest returning a null delegate
unless one is specified in the rule system? Otherwise, you'll risk
breaking the current implementations others :) Either that, or make
the default delegate not work differently from the old behavior. If
given the choice of making the default less useful/require more setup,
or simply not using a default unless specified, I personally would
choose the nicer default, but make the delegate null unless
specifically enabled for backwards compatibility. At least if you're
setting a default, you kinda know what you're getting yourself into.
Also, validation errors are not clearing correctly. If I do an empty
search and then search with a non null string, it continues to tell me
to 'please provide query criteria.' If I put a
setErrorMessage(null);
after line 240 of ERD2WQueryPage, it seems to fix that problem. I'll
submit a patch to jira containing both suggestions.
Ramsey
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden