• Open Menu Close Menu
  • Apple
  • Shopping Bag
  • Apple
  • Mac
  • iPad
  • iPhone
  • Watch
  • TV
  • Music
  • Support
  • Search apple.com
  • Shopping Bag

Lists

Open Menu Close Menu
  • Terms and Conditions
  • Lists hosted on this site
  • Email the Postmaster
  • Tips for posting to public mailing lists
Re: Most requested stuff on Google Moderator
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Most requested stuff on Google Moderator


  • Subject: Re: Most requested stuff on Google Moderator
  • From: Farrukh Ijaz <email@hidden>
  • Date: Wed, 28 Mar 2012 10:31:04 +0300


On 2012-03-28, at 9:22 AM, David Avendasora wrote:


On Mar 28, 2012, at 2:13 PM, Johann Werner wrote:

Perhaps now it is the time to define a mandatory Wonder code formatter all commits have to use. I think that would make it easier for many committers to send patches without worrying about formatting – and it would improve the code readability/quality.

Code formatting can turn into a religious war. Lots of fervent belief, with little evidence to back it up.

I _love_ how I format my code. I've had other's heads explode when they look at it. (Hi Dawn!)

WIth that said, I think some basics would certainly be helpful, and it's easy to create a set of formatting rules that can be imported into Eclipse.

I'd say #1 change that would make the code easier for me to read is no freakin' conditionals in the return statement.

return contentDisposition != null && (contentDisposition.indexOf("inline") > -1 || contentDisposition.indexOf("attachment") > -1);

Seriously, who can read that and make sense of it immediately?!

This is programmers shorthand. They master it with time. If you find these statements somewhere in the code, consider that piece of code been written by an experienced programmer which is less likely to have bugs. This is style is still not difficult than what you can find in a TopCoder algorithm which contains is full of boolean and bit manipulation operators.

I would say, whoever can contribute a single bit, just do it. Formatting is not a major issue. I would do what the following statement returns :)

return "does it exist what you're looking for" ? ("do you find any performance issues" ? "improve, use and share" : "use and appreciate") : "implement, use and share";

Farrukh


Dave

—————————————————————————————
WebObjects - so easy that even Dave Avendasora can do it!™
—————————————————————————————
David Avendasora
Senior Software Abuser
Kaiten, Inc.



Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (email@hidden) Help/Unsubscribe/Update your Subscription: This email sent to email@hidden
  • Follow-Ups:
    • Re: Most requested stuff on Google Moderator
      • From: David Avendasora <email@hidden>
References: 
 >Most requested stuff on Google Moderator (From: Pascal Robert <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Pascal Robert <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Mike Schrag <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Pascal Robert <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Ted Archibald <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Paul Hoadley <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: ISHIMOTO Ken <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: Johann Werner <email@hidden>)
 >Re: Most requested stuff on Google Moderator (From: David Avendasora <email@hidden>)

  • Prev by Date: Re: Most requested stuff on Google Moderator
  • Next by Date: Re: EODataSource
  • Previous by thread: Re: Most requested stuff on Google Moderator
  • Next by thread: Re: Most requested stuff on Google Moderator
  • Index(es):
    • Date
    • Thread