Re: Handling of "value" binding on ERXSubmitButton changed
Re: Handling of "value" binding on ERXSubmitButton changed
- Subject: Re: Handling of "value" binding on ERXSubmitButton changed
- From: email@hidden
- Date: Fri, 28 Jun 2013 17:20:50 -0400
I prefer to say it with: with great power comes great responsibility.
I miss Anjo. I remember when committers who broke things were
expected to fix them.
On Jun 26, 2013, at 11:50 PM, Johann Werner wrote:
Where is the pull request :-)
Am 26.06.2013 um 22:49 schrieb Fabian Peters
<email@hidden>:
I got lucky and found the change that caused my problem:
<https://github.com/wocommunity/wonder/commit/46baf84e143913e945de59364b5f7ec1f2b9c630#L30R119>
Adding back the (empty) takeValuesFromRequest method to my
ERXSubmitButton subclass makes it work again. Is nobody else using
ERXSubmitButton these days?
Fabian
Am 26.06.2013 um 17:35 schrieb Fabian Peters:
Hi all,
After updating Wonder from an integration-branch version dated
2012-11-25 to one dated 2013-06-08, an old application that uses
ERXSubmitButton quite a bit, is throwing the exception quoted below.
I have confirmed that this is due to the updated wonder frameworks,
by going back to the previous set of wonder frameworks, while keeping
the current version of the application and internal framework code.
Removing the value binding doesn't help, as it will then default to
"Save".
The same error message ("Cannot set value to 'Foo' in component
'bar' because value is not settable") was once posted to the list:
<http://lists.apple.com/archives/webobjects-dev/2013/Feb/msg00103.html>
Which makes me think that the commit that changed the behaviour
occurred some time between 2012-11-25 and 2013-02-09. I've looked
through the commits of ERXSubmitButton, ERXWOForm, ERXComponent,
ERXSession, ERXAjaxApplication, ERXComponentRequestHandler and
ERXApplication, but could not find anything "suspicious".
Before I start some lengthy debug session: Does someone have an idea
what could be causing this?
Fabian
WARN 25 Jun 2013 19:45:14,575 elumoApp[-:7878 1] 48,62 MB/32,44 MB
NSLog :44 -
<er.extensions.appserver.ERXComponentRequestHandler>: Exception
occurred while handling request:
java.lang.IllegalStateException:
<ognl.helperfunction.WOHelperFunctionConstantValueAssociation:
value=Save>: Cannot set value to 'Save' in component
'com.elumo.app.CustomerBrowserPage' because value is not settable.
[2013-6-25 19:45:14 MESZ] <WorkerThread3>
java.lang.IllegalStateException:
<ognl.helperfunction.WOHelperFunctionConstantValueAssociation:
value=Save>: Cannot set value to 'Save' in component
'com.elumo.app.CustomerBrowserPage' because value is not settable.
at
com.webobjects.appserver._private.WOConstantValueAssociation.setValue(WOConstantValueAssociation.java:44)
at
com.webobjects.appserver._private.WOInput.takeValuesFromRequest(WOInput.java:87)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
er.extensions.components._private.ERXWOForm.takeValuesFromRequest(ERXWOForm.java:281)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver._private.WOConditional.takeValuesFromRequest(WOConditional.java:79)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver._private.WOConditional.takeValuesFromRequest(WOConditional.java:79)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver._private.WOConditional.takeValuesFromRequest(WOConditional.java:79)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver._private.WOComponentContent.takeValuesFromRequest(WOComponentContent.java:26)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WOGenericContainer.takeValuesFromRequest(WOGenericContainer.java:22)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WOGenericContainer.takeValuesFromRequest(WOGenericContainer.java:22)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WOGenericContainer.takeValuesFromRequest(WOGenericContainer.java:22)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver.WOComponent.takeValuesFromRequest(WOComponent.java:1051)
at
er.extensions.components.ERXComponent.takeValuesFromRequest(ERXComponent.java:143)
at
com.elumo.app.AbstractSubComponent.takeValuesFromRequest(AbstractSubComponent.java:118)
at
com.webobjects.appserver._private.WOComponentReference.takeValuesFromRequest(WOComponentReference.java:119)
at
com.webobjects.appserver._private.WODynamicGroup.takeChildrenValuesFromRequest(WODynamicGroup.java:84)
at
com.webobjects.appserver._private.WODynamicGroup.takeValuesFromRequest(WODynamicGroup.java:93)
at
com.webobjects.appserver.WOComponent.takeValuesFromRequest(WOComponent.java:1051)
at
er.extensions.components.ERXComponent.takeValuesFromRequest(ERXComponent.java:143)
at
com.webobjects.appserver.WOSession.takeValuesFromRequest(WOSession.java:1331)
at
er.extensions.appserver.ERXSession.takeValuesFromRequest(ERXSession.java:559)
at
com.webobjects.appserver.WOApplication.takeValuesFromRequest(WOApplication.java:1724)
at
er.extensions.appserver.ajax.ERXAjaxApplication.takeValuesFromRequest(ERXAjaxApplication.java:97)
at
er.extensions.appserver.ERXComponentRequestHandler._dispatchWithPreparedPage(ERXComponentRequestHandler.java:150)
at
er.extensions.appserver.ERXComponentRequestHandler._dispatchWithPreparedSession(ERXComponentRequestHandler.java:235)
at
er.extensions.appserver.ERXComponentRequestHandler._dispatchWithPreparedApplication(ERXComponentRequestHandler.java:268)
at
er.extensions.appserver.ERXComponentRequestHandler._handleRequest(ERXComponentRequestHandler.java:302)
at
er.extensions.appserver.ERXComponentRequestHandler.handleRequest(ERXComponentRequestHandler.java:378)
at
com.webobjects.appserver.WOApplication.dispatchRequest(WOApplication.java:1687)
at
er.extensions.appserver.ERXApplication.dispatchRequestImmediately(ERXApplication.java:2109)
at
er.extensions.appserver.ERXApplication.dispatchRequest(ERXApplication.java:2074)
at
com.elumo.foundation.ELApplication.dispatchRequest(ELApplication.java:271)
at com.elumo.app.Application.dispatchRequest(Application.java:189)
at
com.webobjects.appserver._private.WOWorkerThread.runOnce(WOWorkerThread.java:144)
at
com.webobjects.appserver._private.WOWorkerThread.run(WOWorkerThread.java:226)
at java.lang.Thread.run(Thread.java:680)
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden