| Alright, I can see now that it is pending inclusion into the Wonder7 branch as it does not support Java5.
In another thread we are discussing moving the Wonder_7 to become the new master and having it target Java 8, at which point this can be pulled in.
Hopefully we can move forward with this in the next couple weeks.
Ted, while this is certainly a scary update, the fact that you worked with the jGroups author and have it running in production are excellent notes to have in the pull request so the committers have an idea of the due-diligence you put in!
Dave On May 1, 2015, at 9:29 AM, David Avendasora < email@hidden> wrote:
Doing something about this, right now. On May 1, 2015, at 9:20 AM, Theodore Petrosky < email@hidden> wrote:
when I did the update, I worked with ‘bela’
this is from an email I sent in Jan 2015:
There are some internals that had to be adjusted, but when I updated ERJGroupsSynchronizer, I worked directly with Bela (jGroups author) to understand the changes needed. In a nutshell, he eliminated his Exception checking and changed to use the Java Exceptions. remove the section:
if (ERXProperties.booleanForKeyWithDefault("er.extensions.jgroupsSynchronizer.autoReconnect", true)) { _channel.setOpt(Channel.AUTO_RECONNECT, Boolean.TRUE); } as (in his words) Shunning was removed a long time ago.
there are a couple of others and he said, <bela__> tedpet: I also suggest use a config file shipped with the version you download, e.g. udp.xml, and then make slight modifications to it, if needed"
I have this working on a production server.
Ted On May 1, 2015, at 9:13 AM, Ken Anderson < email@hidden> wrote: Paul,
These are the basic reasons I didn’t tackle this as well. I can’t imagine anyone would want to use the very old JGroups jar, but who knows? Maybe we need a way for someone to post feedback so that we can determine whether or not it’s OK to upgrade.
Ken On May 1, 2015, at 9:10 AM, Paul Hoadley < email@hidden> wrote:
Hi Ted,
On 1 May 2015, at 10:05 pm, Theodore Petrosky < email@hidden> wrote:
don’t know if this is of interest but I created a pull request for this:
Thanks for pointing this out. I didn’t know this pull request was open. It kind of helps to demonstrate, though, why I was reluctant to touch the framework directly myself—I simply don’t know enough about it. What I got running on EC2, for example, uses the 3.4.0 JAR. Does this matter? I don’t know. Does updating 2.6.8 to 3.4.0 (let alone 3.6.1) cause backward-compatibility issues? I don’t know. Mike Schrag wrote it, and he’s long gone—does anyone else understand it deeply? I don’t know.
This also ties in nicely with the thread started by Jean Pierre Malrieu the other day. A pull request like Ted’s doesn’t sit there for three months untouched because no one cares, it’s because no one _dares_.
—————————————————————————————
WebObjects - so easy that even Dave Avendasora can do it!™ ————————————————————————————— David Avendasora Senior Software Abuser Nekesto, Inc.
—————————————————————————————
WebObjects - so easy that even Dave Avendasora can do it!™ ————————————————————————————— David Avendasora Senior Software Abuser Nekesto, Inc.
|