Re: Minutiae of NSValidation in ERXGenericRecord and ERXPartialGenericRecord
Re: Minutiae of NSValidation in ERXGenericRecord and ERXPartialGenericRecord
- Subject: Re: Minutiae of NSValidation in ERXGenericRecord and ERXPartialGenericRecord
- From: Paul Hoadley <email@hidden>
- Date: Fri, 05 Aug 2016 17:43:09 +0930
Just to keep things out in the open...
On 1 Aug 2016, at 10:32 AM, Paul Hoadley <email@hidden> wrote:
> Surely that should be result = partial.validateValueForKey(result, key), or else a modification by partial P1 gets wiped out by a partial P2 further down the list that doesn’t want to do anything with that key (and hence returns ‘value’ unmodified). Does anyone disagree?
Johann’s opened a pull request with additional minor changes and documentation:
https://github.com/wocommunity/wonder/pull/791
Looks good to me.
> 2. I don’t know what ERXEntityClassDescription.validateObjectWithUserInfo() does,
Turns out I walked right past the documentation: class-level Javadocs describe what’s going on here. This must be some ancient code.
> but currently (see above) it’s also being passed the original ‘value’. Should this method also be passed ‘result’ at this point?
I think it should, at least for consistency, though this validation approach doesn’t coerce the value. This is also in #791 above.
--
Paul Hoadley
http://logicsquad.net/
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden