Re: Duplicated ERJavaMail.framework
Re: Duplicated ERJavaMail.framework
- Subject: Re: Duplicated ERJavaMail.framework
- From: Fabian Peters <email@hidden>
- Date: Thu, 08 Sep 2016 08:00:31 +0200
Hi Paul,
Thanks for looking into this and bonus points for thinking of the maven users!
From what I see, the two frameworks in "Mail" are not being considered for maven builds. Meaning the maven build contains the version from "Core" for now. To move forward we'd have to:
* add a pom file to the "Mail" directory to build ERJavaMail in the new location
* update the groupId in the ERJavaMail pom file
* update the groupId in the dependencyManagement section of the main pom file
Which will be easy to do, so I'd say: go ahead!
Fabian
> Am 08.09.2016 um 02:21 schrieb Paul Hoadley <email@hidden>:
>
> Hello,
>
> As noted by Flavio in another thread, there seems to be two versions of ERJavaMail in the Wonder repo.
>
> 1. Ray committed fe953bf8 on 5 October 2015. This commit copies ERJavaMail from Frameworks/Core to Frameworks/Mail, without deleting the former. It also updates Build/build/build.xml so that the version in Frameworks/Mail is the one being built. Additionally it puts ERCMail.framework in Frameworks/Mail, though I don't know where this came from. (Ray's log message suggests this was factored out of the business logic framework, though there are no changes anywhere else, just additions to Frameworks/Mail, in this commit.)
>
> 2. Build/build/build.xml still shows that it's the Frameworks/Mail version being built for the ERJavaMail.all target. If you download the frameworks from the WOCommunity Jenkins, you can see it’s still got the JARs from 2015, for example, none of the updates.
>
> 3. Meanwhile, the version in Frameworks/Core has had a whole bunch of commits since 5 October 2015, including removal of deprecated methods, updates to libraries, bumps to Java settings, and so on.
>
> I’d be tempted to do this:
>
> 1. Delete Frameworks/Mail/ERJavaMail. There have been no updates to this point in the tree since it was moved there.
>
> 2. Move Frameworks/Core/ERJavaMail to Frameworks/Mail/ERJavaMail. Why? Because that’s what is currently being built, so it shouldn’t require any build changes, and otherwise ERCMail would be orphaned in Frameworks/Mail.
>
> Any thoughts? Is this likely to have any Maven side-effects? (That’s not something I would know how to test.)
>
>
> --
> Paul Hoadley
> http://logicsquad.net/
>
>
> _______________________________________________
> Do not post admin requests to the list. They will be ignored.
> Webobjects-dev mailing list (email@hidden)
> Help/Unsubscribe/Update your Subscription:
>
> This email sent to email@hidden
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden