• Open Menu Close Menu
  • Apple
  • Shopping Bag
  • Apple
  • Mac
  • iPad
  • iPhone
  • Watch
  • TV
  • Music
  • Support
  • Search apple.com
  • Shopping Bag
 

Lists

Open Menu Close Menu
  • Terms and Conditions
  • Lists hosted on this site
  • Email the Postmaster
  • Tips for posting to public mailing lists
Changes
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Changes


  • Subject: Changes
  • From: Mark Wardle <email@hidden>
  • Date: Tue, 20 Sep 2016 21:46:06 +0100

I enclose some simple diffs for wonder 7 - snapshot.

The first is a simple typo but its presence is irritating my sensibilities in my log files.

diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationItem.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationItem.java
index 055add3..6518077 100644
--- a/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationItem.java
+++ b/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationItem.java
@@ -225,7 +225,7 @@
 					}
 				}
 				else {
-					log.warn("For nav core object: {} and child binding: {} recieved binding object: {}", this, childrenBinding(), o);
+					log.warn("For nav core object: {} and child binding: {} received binding object: {}", this, childrenBinding(), o);
 				}
 			}
 		}


The other is a simple fix to navigation menu item, (ERExtensions) which ensures a generated URL stays secure if the current request is secure.

diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationMenuItem.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationMenuItem.java
index 9165d30..03acd48 100644
--- a/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationMenuItem.java
+++ b/Frameworks/Core/ERExtensions/Sources/er/extensions/appserver/navigation/ERXNavigationMenuItem.java
@@ -117,7 +117,7 @@
         	if(_linkDirectlyToDirectActions) {
         		NSMutableDictionary bindings = navigationItem().queryBindings().mutableClone();
         		bindings.setObjectForKey(context().contextID(), "__cid");
-        		url = context().directActionURLForActionNamed(navigationItem().directActionName(), bindings);
+        		url = context().directActionURLForActionNamed(navigationItem().directActionName(), bindings, ERXRequest.isRequestSecure(context().request()), false);
         	} else {
         		url = context().componentActionURL();
         	}



Thanks,

Mark


 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list      (email@hidden)
Help/Unsubscribe/Update your Subscription:

This email sent to email@hidden


  • Prev by Date: EOF inserts already existing M:N relationships/empty snapshot?!?
  • Next by Date: Re: EOF inserts already existing M:N relationships/empty snapshot?!?
  • Previous by thread: Re: EOF inserts already existing M:N relationships/empty snapshot?!?
  • Next by thread: Cannot obtain globalId for an object which...
  • Index(es):
    • Date
    • Thread