Re: More recent PRs for wolifecycle-maven-plugin
Re: More recent PRs for wolifecycle-maven-plugin
- Subject: Re: More recent PRs for wolifecycle-maven-plugin
- From: Hugi Thordarson via Webobjects-dev <email@hidden>
- Date: Mon, 10 Feb 2020 11:04:49 +0000
Hi Paul,
I haven't tried out the new features (currently in bed with pneumonia so I'm
not good for a lot) but I checked out the updated snapshot version and
successfully built a couple of projects with it. So I can at least confirm that
the changes don't seem to break anything (well, for me at least). Thanks for
doing this :).
Cheers,
- hugi
> On 9 Feb 2020, at 23:22, Paul Hoadley via Webobjects-dev
> <email@hidden> wrote:
>
> Hello,
>
> Update: in the absence of any objections, I am going to merge #3 and #4
> today. Johann merged #5 a few days ago. I think #4 is quite uncontroversial,
> and #3 certainly works for me and presumably Ralf.
>
>> On 6 Feb 2020, at 11:41, Paul Hoadley via Webobjects-dev
>> <email@hidden <mailto:email@hidden>>
>> wrote:
>>
>> Hello,
>>
>> In addition to Ralf's work here:
>>
>> * https://github.com/wocommunity/wolifecycle-maven-plugin/pull/3
>> <https://github.com/wocommunity/wolifecycle-maven-plugin/pull/3>
>>
>> I've added a couple of additional PRs:
>>
>> * https://github.com/wocommunity/wolifecycle-maven-plugin/pull/4
>> <https://github.com/wocommunity/wolifecycle-maven-plugin/pull/4> ensures
>> runtime-scoped dependencies are added to the application bundle
>> * https://github.com/wocommunity/wolifecycle-maven-plugin/pull/5
>> <https://github.com/wocommunity/wolifecycle-maven-plugin/pull/5> fixes
>> recent Travis build failures
>>
>> I don't want to merge these before anyone else with skin in the
>> wolifecycle-maven-plugin game has had a chance to review. At the moment,
>> you'd have to pull the relevant branches and Maven-install the plugin in
>> your local repo to try these out. If you're interested and that sounds too
>> hard, let me know and maybe we can work out another way.
>
>
> --
> Paul Hoadley
> https://logicsquad.net/ <https://logicsquad.net/>
> https://www.linkedin.com/company/logic-squad/
>
> _______________________________________________
> Do not post admin requests to the list. They will be ignored.
> Webobjects-dev mailing list (email@hidden)
> Help/Unsubscribe/Update your Subscription:
>
> This email sent to email@hidden
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden