Re: Re: warning: control reaches end of non-void function when using @synchronized
Re: Re: warning: control reaches end of non-void function when using @synchronized
- Subject: Re: Re: warning: control reaches end of non-void function when using @synchronized
- From: "Shawn Erickson" <email@hidden>
- Date: Thu, 7 Sep 2006 14:35:47 -0700
On 9/7/06, Shaun Wexler <email@hidden> wrote:
On Sep 7, 2006, at 10:17 AM, Shawn Erickson wrote:
> (...finally getting time to look into some minor issues I ran into
> over the last few months, anyway...)
>
> I use @synchronized in Objective-C++ built with Xcode 2.3 (using
> ggc-4.0 [1] and have objective-c exceptions enabled) and I get
> "warning: control reaches end of non-void function" when I specify
> -Wall for the following code.
>
> - (BlahParticipant*) getFirstOrganizer
> {
> @synchronized (self) {
> return [[firstOrganizer copy] autorelease];
> }
> }
>
> I may be thinking to much like Java but this seems like an incorrect
> warning... I will file a defect shortly unless folks point out an
> issue with the code.
It's a compiler/language bug. FTA, I wanted to point out that code
should spend the shortest time possible within critical sections. If
there's something that you can perform outside of the synchronized
block, do it before/after.
- (BlahParticipant *)getFirstOrganizer
{
BlahParticipant *firstCopy;
@synchronized(self) {
firstCopy = [firstOrganizer copy];
}
return [firstCopy autorelease];
}
Yeah I agree but in this case the code involved is in no way hot code.
Of course with that said I could kill the warning and reduce the work
in the critical section... tow birds with one stone.
Thanks for confirming what I thought.
- Shawn
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Xcode-users mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden