Re: get rid of warning "suggest parenthesis around assignment used as truth value"
Re: get rid of warning "suggest parenthesis around assignment used as truth value"
- Subject: Re: get rid of warning "suggest parenthesis around assignment used as truth value"
- From: Jim Correia <email@hidden>
- Date: Thu, 20 Nov 2008 16:31:05 -0500
On Nov 20, 2008, at 10:18 AM, Clark S. Cox III wrote:
The fact that I used '=' conveys that I meant to use '=' :)
But seriously, I can't think of a single instance (outside of
school) that I've read (or written) code in which someone wrote '='
when they meant '=='.
It seems like such an obvious mistake that, even if/when it does
happen, it would be caught almost immediately by running the code or
via a unit test.
Our experience differs.
It is a fairly easy typo to make, and is easy to step over the code in
the debugger without noticing the assignment side effect.
Worse, when you didn't write the original code, is determining what
the author meant.
As such, I discourage assignments inside a conditional, without also
making them explicit.
My opinion is that you are writing code for the compiler *and* the
next person who is going to come through and read it or debug it.
Since I believe an assignment inside of a conditional is ambiguous, it
doesn't meet the second goal, regardless of whether it is correct
(both logically, and from the compiler's perspective.)
Jim
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Xcode-users mailing list (email@hidden)
Help/Unsubscribe/Update your Subscription:
This email sent to email@hidden