[PATCH] More Makefile Cleanup - XDarwin removal
[PATCH] More Makefile Cleanup - XDarwin removal
- Subject: [PATCH] More Makefile Cleanup - XDarwin removal
- From: Jeremy Huddleston <email@hidden>
- Date: Mon, 12 Nov 2007 21:09:54 -0800
Ok, as promised, here's a patch that applies to current git which
removes XDarwin:
http://cloud.cs.berkeley.edu/~jeremy/X11-XDawrin-Removal.patch
--enable-xdarwin is no longer a configure option.
Cleaned up some code in mii which still used INXDARWINAPP conditionals
Removed references to XDarwin files that are not needed in Xquartz
from Makefile.am. They will still remain in git but won't be in a
'make dist'. You should probably remove them from git as well. I can
make a list of them if you'd like.
Also included are changes submitted a couple hours ago but not yet in
git:
compile time should be cut in half since we were previously
compiling things twice (once for libXquartz and once right into
Xquartz) as well as things we didn't need (iokit)
apple/X11{Application,controler}.m are included in quartz/
libXquartz.a instead of the old XDarwin counterparts
Xquartz man page gets installed
Also, you might want to move apple/X11{Application,controler}.* into
quartz instead of apple. Others might be confused as I was and think
they're in X11.app
Additionally, apple/Xquartz.man should probably be moved into the
parent dir, so it's more obvious and the apple dir will then hold just
X11.app
--Jeremy
On Nov 12, 2007, at 8:05 PM, Ben Byer wrote:
On Nov 12, 2007, at 6:33 PM, Jeremy Huddleston wrote:
This patch supersedes the patch I emailed this afternoon (ie, it
contains those changes already). This patch contains the following
changes:
launcher was missing from 'make dist'
quartz was not in 'make dist' unless --enable-quartz was set in
configure
make clean removes {launcher,apple}/build
fixed $(prefixdir) to $(prefix)
X11.app now installs with mode u+w since I was getting annoyed with
having to fix that each time.
Compile time should be cut in half since we were previously
compiling things twice (once for libXquartz and once right into
Xquartz) as well as things we didn't need (iokit)
apple/X11{Application,controler}.m are included in quartz/
libXquartz.a instead of the old XDarwin counterparts
Xquartz man page gets installed
General overall cleanup
It still leaves in build support for the not-working XDarwin (which
I'm in favor of removing completely). If you'd like, I can submit
a patch which removes it completely.
Sure, go for it. Bonus points for it applying cleanly to git (as I
think I already applied your superseded patch.)
--
Ben Byer
CoreOS / BSD Technology Group, XDarwin maintainer
_______________________________________________
Do not post admin requests to the list. They will be ignored.
X11-users mailing list (email@hidden)
This email sent to email@hidden